[Fedora-livecd-list] kickstart.py: except IOError, (err, msg): ValueError: need more than 1 value to unpack

[Bruno Wolff III]

On Fri, Jul 23, 2010 at 15:22:28 +0100,
  Marc Herbert <Marc.Herbert at gmail.com> wrote:
> Insert a typo in the name of a %include(d) file. Run "livecd-creator". You get the cryptic:
> 
> Traceback (most recent call last):
>   File "/usr/bin/livecd-creator", line 140, in <module>
>     sys.exit(main())
>   File "/usr/bin/livecd-creator", line 112, in main
>     ks = imgcreate.read_kickstart(options.kscfg)
>   File "/usr/lib/python2.6/site-packages/imgcreate/kickstart.py", line 56, in read_kickstart
>     except IOError, (err, msg):
> ValueError: need more than 1 value to unpack
> 
> 
> The following patch works around the problem. It is probably NOT a fix but a workaround!

The other issue is likely that one of the packages needed in the livecd-desktop
image is no longer in rawhide. I want to remake the spin-kickstart packages
but am waiting for desktop to revert their patch adding a yum remove in
post, before doing so.

A work around is to get a local git clone of the spin-kickstarts git repo.

> I suspect this is far from the only place to find this bug.

Thanks. I'll need to look at that, since I think I touched some stuff
related to that and may have missed something.

> --- a/imgcreate/kickstart.py
> +++ b/imgcreate/kickstart.py
> @@ -53,7 +53,7 @@ def read_kickstart(path):
>      try:
>          ksfile = urlgrabber.urlgrab(path)
>          ks.readKickstart(ksfile)
> -    except IOError, (err, msg):
> +    except IOError, (msg):
>          raise errors.KickstartError("Failed to read kickstart file "
>                                      "'%s' : %s" % (path, msg))
>      except kserrors.KickstartError, e: