[Fedora-livecd-list] Patch review request for exception handling

[Jasper Hartline]

I have tested normal livecd creation, I have also tested
livecd-creation with invalid kickstart data
and these patches work fine in the short run. I would like to see these patches
committed as this provides temporary relief of the underlying issues
with pykickstart
and urlgrabber in the immediate time frame.

This will buy us time to work on fixing the underlying issues mentioned above.
Thanks Bruno, +1 from me.

> Going down this road, I have something worked up that would need to be
> tested before committing. The patch is attached.
>
> The git commit log:
>
>    Fix issue with improper exception args used by urlgrabber and pykickstart.
>
>    urlgrabber and pykickstart don't always supply both and error number and
>    an error message when raising an IOError exception. This was causing
>    an exception while processing the exception for some errors.
>
>    To prevent exceptions from insufficient arguments, the exception calls
>    were changed to use a single variable instead of a tuple and to use
>    strerror instead of the second argument.
>
>    As a temporary work around for urlgrabber and pykickstart issues, if
>    strerror is null, args[0] is used as a fallback so that we get a
>    reasonable error message.
>
>    This resolves bug 551932.