[Fedora-livecd-list] [PATCH] 'ImageCreator' object has no attribute '_fstype'

[Leo Baltus]

Hi,

When calling ImageCreator directly it seems it is missing _fstype.

Attached patch adds this to the ImageCreator class.

steps to reproduce:

    creator = imgcreate.ImageCreator(ks, name, None, tmp)
    creator.create()

...

  File "/usr/lib/python2.7/site-packages/imgcreate/creator.py", line 235, in _get_fstab
    s =  "/dev/root  /         %s    defaults,noatime 0 0\n" %(self._fstype)
AttributeError: 'ImageCreator' object has no attribute '_fstype'

This is on Centos Linux 7, using python-imgcreate-20.1-2.el7.x86_64

I hope this patch is suitable for inclusion in future releases.

-- 
Leo Baltus, internetbeheerder
NPO ICT Internet Services
Bart de Graaffweg 2, 1217 ZL Hilversum
-------------- next part --------------
--- imgcreate/creator.py.org	2014-08-24 13:03:06.623608872 +0200
+++ imgcreate/creator.py	2014-08-24 12:52:23.270674918 +0200
@@ -89,6 +89,7 @@
         self.__bindmounts = []
 
         self.__sanity_check()
+        self._fstype = kickstart.get_image_fstype(self.ks, "ext3")
 
         # get selinuxfs mountpoint
         self.__selinux_mountpoint = "/sys/fs/selinux"