<br><br><div class="gmail_quote">On Fri, May 7, 2010 at 1:04 PM, Frederick Grose <span dir="ltr"><<a href="mailto:fgrose@gmail.com">fgrose@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="gmail_quote"><div><div></div><div class="h5">On Fri, May 7, 2010 at 12:28 PM, <span dir="ltr"><<a href="mailto:apevec@gmail.com" target="_blank">apevec@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Alan Pevec <<a href="mailto:apevec@redhat.com" target="_blank">apevec@redhat.com</a>><br>
<br>
Resolves: rhbz#583658<br>
<br>
Signed-off-by: Alan Pevec <<a href="mailto:apevec@redhat.com" target="_blank">apevec@redhat.com</a>><br>
---<br>
tools/livecd-iso-to-disk.sh | 13 +++++++++++++<br>
1 files changed, 13 insertions(+), 0 deletions(-)<br>
<br>
diff --git a/tools/livecd-iso-to-disk.sh b/tools/livecd-iso-to-disk.sh<br>
index 3a4726d..f4d0855 100755<br>
--- a/tools/livecd-iso-to-disk.sh<br>
+++ b/tools/livecd-iso-to-disk.sh<br>
@@ -138,6 +138,18 @@ checkPartActive() {<br>
fi<br>
}<br>
<br>
+checkLVM() {<br>
+ dev=$1<br>
+<br>
+ if [ -x /sbin/pvs -a \<br>
+ "$(/sbin/pvs -o vg_name --noheadings $dev* 2>/dev/null)" ]; then<br>
+ echo "Device, $dev, contains a volume group and cannot be formated!"<br>
+ echo "You can remove the volume group using vgremove."<br>
+ exitclean<br>
+ fi<br>
+ return 0<br>
+}<br>
+<br>
createGPTLayout() {<br>
dev=$1<br>
getdisk $dev<br>
@@ -407,6 +419,7 @@ fi<br>
# do some basic sanity checks.<br>
checkMounted $USBDEV<br>
if [ -n "$format" ];then<br>
+ checkLVM $USBDEV<br>
# checks for a valid filesystem<br>
if [ -n "$efi" ];then<br>
createGPTLayout $USBDEV<br>
--<br>
1.6.0.6</blockquote><div><br></div></div></div><div>Redirecting standard error leads to silent failure when the lvm2 tools are not installed.</div><div><br></div><div>I've suggested leaving out that redirection so as to leave a hint for the user in that situation.</div>
<div><br></div><div> --Fred</div></div>
</blockquote></div><br><div>Sorry, I see the additional test now.</div><div> --Fred</div>