mingw32-nsiswrapper with gtk3

[Erik van Pienbroek]

Nerijus Baliunas schreef op wo 13-07-2011 om 23:50 [+0300]:
> Hello,
> 
> I used nsiswrapper --run --with-gtk and it was unable to find 2 gtk-2.0 directories.
> My application depends on gtk3, so I had to use this patch for /usr/bin/nsiswrapper:
> 
> --- nsiswrapper.orig    2011-02-08 21:55:05.000000000 +0200
> +++ nsiswrapper 2011-07-13 21:23:54.452033666 +0300
> @@ -515,12 +515,12 @@
>  sub do_gtk
>  {
>      add_file_unless_exists (
> -       "$mingw32_libdir/gtk-2.0",
> +       "$mingw32_libdir/gtk-3.0",
>         root => 0,
>         dir => 1,
>         exec => 0,
>         install_dir => "lib",
> -       install_name => "gtk-2.0"
> +       install_name => "gtk-3.0"
>         );
> 
>      add_file_unless_exists (
> @@ -542,12 +542,12 @@
>         );
> 
>      add_file_unless_exists (
> -       "$mingw32_sysconfdir/gtk-2.0",
> +       "$mingw32_sysconfdir/gtk-3.0",
>         root => 0,
>         dir => 1,
>         exec => 0,
>         install_dir => "etc",
> -       install_name => "gtk-2.0"
> +       install_name => "gtk-3.0"
>         );
> 
>      add_file_unless_exists (
> 
> Could nsiswrapper be extended to support gtk3 too?

Thanks for your contribution.

Does this change make nsiswrapper only include gtk3 and not the gtk2
libraries anymore? If that's the case then it'll be a change in behavior
which several people (who are depending on nsiswrapper to bundle the
gtk2 libraries) probably won't like. I think a better solution would be
to change the script so that it supports both '--with-gtk2' and
'--with-gtk3' so that users can decide for themselves whether they want
to bundle gtk2 or gtk3 with their installers.

Regards,

Erik van Pienbroek