[Bug 722707] Review Request: mingw-libvorbis - MinGW Windows libvorbis library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722707

Paweł Forysiuk <tuxator at o2.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tuxator at o2.pl

--- Comment #2 from Paweł Forysiuk <tuxator at o2.pl> 2011-07-16 18:26:37 EDT ---
This is an unoffical review of mingw-libvorbis package. I'm still looking for a
Sponsor.

rpmlint mingw-libvorbis-1.3.2-1.fc15.src.rpm mingw-libvorbis.spec
~/rpmbuild/RPMS/noarch/mingw32-libvorbis-1.3.2-1.fc15.noarch.rpm
~/rpmbuild/RPMS/noarch/mingw32-libvorbis-debuginfo-1.3.2-1.fc15.noarch.rpm 
mingw-libvorbis.src: W: spelling-error %description -l en_US Ogg -> Egg, Org,
Soggy
mingw-libvorbis.src: W: spelling-error %description -l en_US bitrates ->
nitrates, bit rates, bit-rates
mingw-libvorbis.src: W: spelling-error %description -l en_US kbps -> bps, kips,
k bps
mingw-libvorbis.src: E: changelog-time-in-future 2011-07-17

mingw32-libvorbis.noarch: W: spelling-error %description -l en_US Ogg -> Egg,
Org, Soggy
mingw32-libvorbis.noarch: W: spelling-error %description -l en_US bitrates ->
nitrates, bit rates, bit-rates
mingw32-libvorbis.noarch: W: spelling-error %description -l en_US kbps -> bps,
kips, k bps
mingw32-libvorbis.noarch: E: changelog-time-in-future 2011-07-17

mingw32-libvorbis-debuginfo.noarch: E: changelog-time-in-future 2011-07-17
mingw32-libvorbis-debuginfo.noarch: E: debuginfo-without-sources
3 packages and 1 specfiles checked; 4 errors, 6 warnings.


+ rpmlint errors are false positives here.
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name match the base package name.
+ The package meets the Packaging Guidelines

+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
  native Fedora package
+ The package contains the license file (COPYING)

+ Spec file is written in American English
+ Spec file is legible

+ Upstream sources match sources in the srpm. md5sum:
 c870b9bd5858a0ecb5275c14486d9554  libvorbis-1.3.2.tar.gz
 c870b9bd5858a0ecb5275c14486d9554 
/home/pawel/rpmbuild/SOURCES/libvorbis-1.3.2.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable

+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros

+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
    Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
    Fedora MinGW guidelines allow .la files

n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.