[Bug 756776] Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=756776

--- Comment #5 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> ---
Okay, let's go:
- The BuildRoot tag is not needed any more with modern RPM, so it can be
removed
- The Requires: pkgconfig is currently mentioned in the global section (the
mingw-libosinfo). However, as no mingw-libosinfo binary rpm is generated, this
Requires flag doesn't have any effect. You might want to move it to the
%package sections for the mingw32-libosinfo and mingw64-libosinfo packages
- The quotes which you used in the %mingw_make_install
"DESTDIR=$RPM_BUILD_ROOT" aren't needed any more and can be removed
- The %defattr tags in the %files sections is also unneeded with modern RPM

-- 
You are receiving this mail because:
You are on the CC list for the bug.