[Bug 832007] Review Request: mingw-webkitgtk3 - MinGW Windows GTK+ Web content engine library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=832007

Paweł Forysiuk <tuxator at o2.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tuxator at o2.pl
              Flags|                            |fedora-review+

--- Comment #2 from Paweł Forysiuk <tuxator at o2.pl> ---
Fedora review of mingw-webkitgtk3-1.8.1-1.fc17.src.rpm 2012-06-28


[+] rpmlint must be run on the source rpm and all binary rpms the build
produces

rpmlint mingw-webkitgtk3.spec mingw-webkitgtk3-1.8.1-1.fc17.src.rpm
mingw32-webkitgtk3-debuginfo-1.8.1-1.fc17.noarch.rpm
mingw32-webkitgtk3-1.8.1-1.fc17.noarch.rpm
mingw64-webkitgtk3-debuginfo-1.8.1-1.fc17.noarch.rpm
mingw64-webkitgtk3-1.8.1-1.fc17.noarch.rpm 

mingw-webkitgtk3.src: I: enchant-dictionary-not-found en_US
mingw32-webkitgtk3-debuginfo.noarch: E: debuginfo-without-sources
mingw64-webkitgtk3-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 1 specfiles checked; 2 errors, 0 warnings.

   Warnings from rpmlint output are a false positive.

[+] Package is named according to the Package Naming Guidelines (For MinGW
packages).
[+] The spec file name match the base package %{name}
[+] Package is licensed with Fedora approved license.
[+] License filed in package matches actual license.
[+] Other included licenses are packaged in %doc
[+] Spec file is written in American English
[+] Spec file is legible
[+] Source used to build matches the upstream source

sha1sum webkit-1.8.1.tar.xz ~/rpmbuild/SOURCES/webkit-1.8.1.tar.xz 
d26543baace03c31aa3de82bc24f06f14c6b3052  webkit-1.8.1.tar.xz
d26543baace03c31aa3de82bc24f06f14c6b3052 
/home/pawel/rpmbuild/SOURCES/webkit-1.8.1.tar.xz

[+] Package compiles and builds successfully
[+] Locales are handled properly
[+] Package does not bundle system libraries
[+] Package owns all directories it creates
[+] Permissions are properly set
[+] All filenames are valid UTF-8 


Package works very nice when used with cross-compiled Midori browser

-- 
You are receiving this mail because:
You are on the CC list for the bug.