[Bug 858069] Review Request: mingw-qt5-qtlocation - Qt5 for Windows - QtLocation component

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=858069

Michael Cronenworth <mike at cchtml.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Michael Cronenworth <mike at cchtml.com> ---
$ rpmlint
Downloads/mingw-qt5-qtlocation-5.0.0-0.6.git20130510.f2840834.fc20.src.rpm 
mingw-qt5-qtlocation.src: E: unknown-key GPG#9b393ae8
mingw-qt5-qtlocation.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtlocation.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtlocation.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtlocation.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtlocation.src: W: invalid-url Source0:
qt5-qtlocation-f2840834.tar.gz
1 packages and 0 specfiles checked; 1 errors, 6 warnings.

$ rpmlint Downloads/mingw-qt5-qtlocation.spec 
Downloads/mingw-qt5-qtlocation.spec:26: W: macro-in-comment %{qt_module}
Downloads/mingw-qt5-qtlocation.spec:26: W: macro-in-comment %{snapshot_rev}
Downloads/mingw-qt5-qtlocation.spec:26: W: macro-in-comment %{qt_module}
Downloads/mingw-qt5-qtlocation.spec:26: W: macro-in-comment %{snapshot_rev}
Downloads/mingw-qt5-qtlocation.spec: W: invalid-url Source0:
qt5-qtlocation-f2840834.tar.gz
0 packages and 1 specfiles checked; 0 errors, 5 warnings.


+ OK
! needs attention

+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
n/a The stated license is the same as the one for the corresponding
  native Fedora package
+ The package contains the license file (COPYING.lib)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  2bef598a14cbff37021305dda6f0c550  Downloads/qt5-qtlocation-f2840834.tar.gz
  2bef598a14cbff37021305dda6f0c550  SOURCES/qt5-qtlocation-f2840834.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

-----
Summary:
- Looks good!

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jA8y7np5IN&a=cc_unsubscribe