[Bug 851680] Review Request: mingw-libidl - MinGW Windows IDL Parsing Library.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=851680

Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |erik-fedora at vanpienbroek.nl
           Assignee|nobody at fedoraproject.org    |erik-fedora at vanpienbroek.nl
              Flags|                            |fedora-review?



--- Comment #1 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> ---
Taking for review

* The %global's mingw_build_win32 and mingw_build_win64 aren't needed any more
and can be removed
* It shouldn't be necessary to use config.cache files. Both these files contain
lt_cv_deplibs_check_method='pass_all'. This indicates that an ancient autoconf
was used to prepare this package which isn't aware of mingw-w64. To resolve
that you can better try to add 'BuildRequires: autoconf automake libtool' and
run 'autoreconf --install --force' in the %prep section
* Manually copying the .def files shouldn't be necessary. More likely one of
the Makefile.am files needs to be updated so that it references to
$(srcdir)/libIDL.def instead of just 'libIDL.def'
* Info files which are also present in native packages don't have to be bundled
in the mingw package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IPmrYrOj0E&a=cc_unsubscribe