[Mingw-w64-public] Mass rebuild report for August 29 2013

[Erik van Pienbroek]

Kai Tietz schreef op do 29-08-2013 om 22:15 [+0200]:
> 2013/8/29 Erik van Pienbroek <erik at vanpienbroek.nl>:
> > Alexey Pavlov schreef op do 29-08-2013 om 23:20 [+0400]:
> >> After fixing tis issue  I have issue described here:
> >> https://bugreports.qt-project.org/browse/QTBUG-33225
> >>
> >
> > Thanks for the info!
> > I just tried the patch you mentioned and it indeed resolves the build
> > failure.
> >
> > Now I'm also seeing the other issue you mentioned:
> >
> > /home/erik/fedora/mingw-qt5-qtbase/qtbase-opensource-src-5.1.1/src/plugins/platforms/windows/qwindowstheme.cpp: In member function 'virtual QPixmap QWindowsTheme::standardPixmap(QPlatformTheme::StandardPixmap, const QSizeF&) const':
> > /home/erik/fedora/mingw-qt5-qtbase/qtbase-opensource-src-5.1.1/src/plugins/platforms/windows/qwindowstheme.cpp:531:13: error: 'SHSTOCKICONINFO' was not declared in this scope
> >              SHSTOCKICONINFO iconInfo;
> >              ^
> > /home/erik/fedora/mingw-qt5-qtbase/qtbase-opensource-src-5.1.1/src/plugins/platforms/windows/qwindowstheme.cpp:531:29: error: expected ';' before 'iconInfo'
> >              SHSTOCKICONINFO iconInfo;
> >                              ^
> > /home/erik/fedora/mingw-qt5-qtbase/qtbase-opensource-src-5.1.1/src/plugins/platforms/windows/qwindowstheme.cpp:532:21: error: 'iconInfo' was not declared in this scope
> >              memset(&iconInfo, 0, sizeof(iconInfo));
> >                      ^
> > /home/erik/fedora/mingw-qt5-qtbase/qtbase-opensource-src-5.1.1/src/plugins/platforms/windows/qwindowstheme.cpp:535:64: error: 'SIID_SHIELD' was not declared in this scope
> >              if
> > (QWindowsContext::shell32dll.sHGetStockIconInfo(SIID_SHIELD, SHGFI_ICON
> > | iconSize, &iconInfo) == S_OK) {
> >                                                                 ^
> >
> > Apparently this is a piece of code which was added in Qt 5.1.1. Qt 5.1.0
> > didn't use these structures yet, so the workaround would be to stay with
> > Qt 5.1.0 for now. I guess these structures have to be implemented in
> > mingw-w64-headers.
> 
> No it is present, and part of shellapi.h header.  Only thing required
> for this structure is to define NTDDI_VERSION >= 0x06000000.  Or
> define _WIN32_WINNT >= 0x0600 and include sdkddkver.h header (it gets
> automatically included by windows.h and some other headers).

Hey Kai,

Thanks for the hint. With this information I was able to come up with a
patch to fix this build issue. I also just proposed this patch for
inclusion upstream: https://codereview.qt-project.org/#change,64144

Regards,

Erik