[Bug 895566] Review Request: mingw-polyclipping - MinGW Polygon clipping library
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jan 19 15:36:10 UTC 2013
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=895566
Miro Hrončok <mhroncok at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(t.sailer at alumni.e
| |thz.ch)
--- Comment #12 from Miro Hrončok <mhroncok at redhat.com> ---
FIX: Now you have Win32 in both 32 and 64 summary.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/mingw-polyclipping-5.0.3-2.fc18.src.rpm
../RPMS/noarch/mingw32-polyclipping-5.0.3-2.fc18.noarch.rpm
../RPMS/noarch/mingw64-polyclipping-5.0.3-2.fc18.noarch.rpm
../RPMS/noarch/mingw32-polyclipping-debuginfo-5.0.3-2.fc18.noarch.rpm
../RPMS/noarch/mingw64-polyclipping-debuginfo-5.0.3-2.fc18.noarch.rpm
mingw-polyclipping.src: W: spelling-error %description -l en_US boolean ->
Boolean, boo lean, boo-lean
mingw32-polyclipping.noarch: W: spelling-error %description -l en_US boolean ->
Boolean, boo lean, boo-lean
mingw64-polyclipping.noarch: W: spelling-error %description -l en_US boolean ->
Boolean, boo lean, boo-lean
mingw32-polyclipping-debuginfo.noarch: E: debuginfo-without-sources
mingw64-polyclipping-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 0 specfiles checked; 2 errors, 3 warnings.
All false positives, OK.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in license.txt, Boost. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ spectool -g mingw-polyclipping.spec
Getting http://downloads.sourceforge.net/polyclipping/clipper_ver5.0.3.zip to
./clipper_ver5.0.3.zip
$ sha256sum ./clipper_ver5.0.3.zip
e48178e84b51b4ef7a1d13c0c6e1536e4e55ade71d893c26ba533915fc98fac3
./clipper_ver5.0.3.zip
$ sha256sum ../SOURCES/clipper_ver5.0.3.zip
e48178e84b51b4ef7a1d13c0c6e1536e4e55ade71d893c26ba533915fc98fac3
../SOURCES/clipper_ver5.0.3.zip
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. OK, builds
in mock
MUST: Packages must NOT bundle copies of system libraries. OK (guess it doesn't
apply on Win builds)
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/mingw32-polyclipping-5.0.3-2.fc18.noarch.rpm
-rwxr-xr-x 1 root root 140202 led 19 16:19
/usr/i686-w64-mingw32/sys-root/mingw/bin/libpolyclipping.dll
drwxr-xr-x 2 root root 0 led 19 16:19
/usr/i686-w64-mingw32/sys-root/mingw/include/polyclipping
-rw-r--r-- 1 root root 11178 led 19 16:19
/usr/i686-w64-mingw32/sys-root/mingw/include/polyclipping/clipper.hpp
-rw-r--r-- 1 root root 86642 led 19 16:19
/usr/i686-w64-mingw32/sys-root/mingw/lib/libpolyclipping.dll.a
drwxr-xr-x 2 root root 0 led 19 16:19
/usr/share/doc/mingw32-polyclipping-5.0.3
-rw-r--r-- 1 root root 1575 čen 18 2011
/usr/share/doc/mingw32-polyclipping-5.0.3/License.txt
-rw-r--r-- 1 root root 10639 led 12 07:42
/usr/share/doc/mingw32-polyclipping-5.0.3/README
$ rpm -q -lv -p ../RPMS/noarch/mingw64-polyclipping-5.0.3-2.fc18.noarch.rpm
drwxr-xr-x 2 root root 0 led 19 16:19
/usr/share/doc/mingw64-polyclipping-5.0.3
-rw-r--r-- 1 root root 1575 čen 18 2011
/usr/share/doc/mingw64-polyclipping-5.0.3/License.txt
-rw-r--r-- 1 root root 10639 led 12 07:42
/usr/share/doc/mingw64-polyclipping-5.0.3/README
-rwxr-xr-x 1 root root 142155 led 19 16:19
/usr/x86_64-w64-mingw32/sys-root/mingw/bin/libpolyclipping.dll
drwxr-xr-x 2 root root 0 led 19 16:19
/usr/x86_64-w64-mingw32/sys-root/mingw/include/polyclipping
-rw-r--r-- 1 root root 11178 led 19 16:19
/usr/x86_64-w64-mingw32/sys-root/mingw/include/polyclipping/clipper.hpp
-rw-r--r-- 1 root root 85104 led 19 16:19
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libpolyclipping.dll.a
OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
$ rpm -q --provides -p
../RPMS/noarch/mingw32-polyclipping-5.0.3-2.fc18.noarch.rpm
mingw32-polyclipping = 5.0.3-2.fc18
mingw32(libpolyclipping.dll)
$ rpm -q --provides -p
../RPMS/noarch/mingw64-polyclipping-5.0.3-2.fc18.noarch.rpm
mingw64-polyclipping = 5.0.3-2.fc18
mingw64(libpolyclipping.dll)
$ rpm -q --requires -p
../RPMS/noarch/mingw32-polyclipping-5.0.3-2.fc18.noarch.rpm
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 83
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libstdc++-6.dll)
mingw32(msvcrt.dll)
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm -q --requires -p
../RPMS/noarch/mingw64-polyclipping-5.0.3-2.fc18.noarch.rpm
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 83
mingw64(kernel32.dll)
mingw64(libgcc_s_sjlj-1.dll)
mingw64(libstdc++-6.dll)
mingw64(msvcrt.dll)
rpmlib(PayloadIsXz) <= 5.2-1
OK
FIX the summary and package can be APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TgXAykHdR1&a=cc_unsubscribe
More information about the mingw
mailing list