[Bug 851677] Review Request: mingw-dbus-glib - D-Bus Message Bus System

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851677

Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |erik-fedora at vanpienbroek.nl
              Flags|                            |fedora-review?

--- Comment #2 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> ---
Taking for review

Regarding your comment about the license: I think it should be good enough to
use the same license tag as used by the native dbus-glib package (thus AFL and
GPLv2+).

Please don't use the %{summary} tags. Each subpackage has a different goal
(win32/win64 and shared/static) so each subpackage should have its own summary.

Why are you using config.cache files? They should only be used when absolutely
necessary. It might be necessary to patch the configure.in file. Patching is
more preferred here as the change can then be proposed for inclusion upstream
and other users can benefit from it as well without having to use hacks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cVAfMZKccq&a=cc_unsubscribe