[Bug 851683] Review Request: mingw-gconf2 - MinGW Windows port of the GNOME 2.x Desktop Configuration Database System

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851683

--- Comment #4 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> ---
$ rpmlint mingw-gconf2.spec 
mingw-gconf2.spec:43: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
line 43)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint mingw-gconf2-3.2.6-1.fc18.src.rpm 
mingw-gconf2.src: E: description-line-too-long C MinGW Windows port of GConf,
the GNOME configuration database. It is used by the GNOME 2.x
mingw-gconf2.src: W: strange-permission mingw-gconf2.spec 0600L
mingw-gconf2.src:43: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line
43)
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

$ rpmlint mingw32-gconf2-3.2.6-1.fc18.noarch.rpm
mingw64-gconf2-3.2.6-1.fc18.noarch.rpm 
mingw32-gconf2.noarch: E: description-line-too-long C MinGW Windows port of
GConf, the GNOME configuration database. It is used by the GNOME 2.x
mingw32-gconf2.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/bin/gsettings-schema-convert
mingw32-gconf2.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw32-gconf2-3.2.6/COPYING
mingw32-gconf2.noarch: W: file-not-utf8
/usr/share/doc/mingw32-gconf2-3.2.6/ChangeLog
mingw32-gconf2.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32
mingw64-gconf2.noarch: E: description-line-too-long C MinGW Windows port of
GConf, the GNOME configuration database. It is used by the GNOME 2.x
mingw64-gconf2.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw64-gconf2-3.2.6/COPYING
mingw64-gconf2.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/bin/gsettings-schema-convert
mingw64-gconf2.noarch: W: file-not-utf8
/usr/share/doc/mingw64-gconf2-3.2.6/ChangeLog
2 packages and 0 specfiles checked; 6 errors, 3 warnings.


$ rpm --query --requires mingw32-gconf2
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 83
mingw32(kernel32.dll)
mingw32(libdbus-1-3.dll)
mingw32(libdbus-glib-1-2.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libgconf-2-4.dll)
mingw32(libgio-2.0-0.dll)
mingw32(libglib-2.0-0.dll)
mingw32(libgmodule-2.0-0.dll)
mingw32(libgobject-2.0-0.dll)
mingw32(libgthread-2.0-0.dll)
mingw32(libintl-8.dll)
mingw32(libxml2-2.dll)
mingw32(msvcrt.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw64-gconf2
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 83
mingw64(kernel32.dll)
mingw64(libdbus-1-3.dll)
mingw64(libdbus-glib-1-2.dll)
mingw64(libgconf-2-4.dll)
mingw64(libgio-2.0-0.dll)
mingw64(libglib-2.0-0.dll)
mingw64(libgmodule-2.0-0.dll)
mingw64(libgobject-2.0-0.dll)
mingw64(libgthread-2.0-0.dll)
mingw64(libintl-8.dll)
mingw64(libxml2-2.dll)
mingw64(msvcrt.dll)
rpmlib(PayloadIsXz) <= 5.2-1


$ rpm --query --provides mingw32-gconf2
mingw32-gconf2 = 3.2.6-1.fc18
mingw32(libgconf-2-4.dll)
mingw32(libgconfbackend-oldxml.dll)
mingw32(libgconfbackend-xml.dll)
mingw32(libgsettingsgconfbackend.dll)

$ rpm --query --provides mingw64-gconf2
mingw64-gconf2 = 3.2.6-1.fc18
mingw64(libgconf-2-4.dll)
mingw64(libgconfbackend-oldxml.dll)
mingw64(libgconfbackend-xml.dll)
mingw64(libgsettingsgconfbackend.dll)


$ wget --quiet
http://ftp.gnome.org/pub/GNOME/sources/GConf/3.2/GConf-3.2.6.tar.xz -O - |
md5sum
2b16996d0e4b112856ee5c59130e822c  -
$ md5sum GConf-3.2.6.tar.xz 
2b16996d0e4b112856ee5c59130e822c  GConf-3.2.6.tar.xz


+ OK
! Needs to be looked into
/ Not applicable

[!] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
    to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[+] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[!] Requires of the binary mingw32 and mingw64 packages are equal


The name of this package is incorrect, the name of the upstream project is
GConf2, not gconf2. Therefore the mingw package has to be named mingw-GConf2

The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64
package doesn't. I don't know what causes it, but it looks harmless to me

The only remaining issue are the various rpmlint errors/warnings. Most of
them are easy to resolve.

The incorrect-fsf-address rpmlint error should be reported upstream

The file-not-utf8 warning can be resolved with an iconv call (various other
Fedora packages also do this, so you could try to peek at other .spec files
for an example)

The non-standard-dir-in-usr warning can be ignored. This looks like a bug
in rpmlint to me


Please update the package name (including the title of this review ticket) and
resolve the remaining rpmlint issues. After that I can approve this package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oZesKRgqTY&a=cc_unsubscribe