[Bug 1122325] Review Request: mingw-libtheora - Theora Video Compression Codec

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1122325



--- Comment #3 from František Dvořák <valtri at civ.zcu.cz> ---
(In reply to David King from comment #2)
> Package Review
> ==============
> 
> Approved! 

Thanks! :-)

> Would be nice to add an INSTALL="install -p" to the make install
> invocation, but this is not a requirement.
> 

Interresting. This little issue is de-facto standard I guess, but it may good
to use it for packages using autotools.

> There is no point including a dependency on SDL, as both SDL and OSS are
> needed to build an example (just SDL is not sufficient), so the dependency
> should be removed.
> 

This is actually funny dependency. SDL itself is not used here, but the m4 file
from SDL-devel (native package!) is needed for autotools invocation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Zv32M003y&a=cc_unsubscribe