[Bug 201941] Review Request: tetex-elsevier
bugzilla at redhat.com
bugzilla at redhat.com
Fri Aug 11 02:24:35 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: tetex-elsevier
tibbs at math.uh.edu changed:
What |Removed |Added
------- Additional Comments From tibbs at math.uh.edu 2006-08-10 22:15 EST -------
There's not much to this package; upstream doesn't distribute this as anything
other than a bunch of separate files. However, one things that concerns me is
the files are essentially unversioned upstream. One thing you might consider
doing is preserving the original file dates, but that might be difficult when
fixing up the line endings.
Also, why do you have BuildRequires: tetex-latex? It doesn't seem to be
required for anything since you're just copying files around.
Otherwise rpmlint is quiet and everything looks good.
* source files match upstream:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
? BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
tetex-elsevier = 0.1.20060416-3.fc6
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets look OK.
* code, not content.
* documentation is small, so no -docs subpackage is necessary. (Actually the
documentation is several times larger than the rest of the package, but the
whole thing is only 500K.)
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review