[Bug 203249] Review Request: kpolynome
bugzilla at redhat.com
bugzilla at redhat.com
Sat Aug 26 14:04:08 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: kpolynome
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203249
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-08-26 10:03 EST -------
Fully checked. The remained things are:
>From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Requires
Requires: kdelibs
Again, why is this exclicit requirement needed?
/usr/bin/kpolynome requires libkdecore.so.4 and this
is included in kdelibs. So this package automatically
requires kdelibs even without the explicit statement
above is not written.
I suspect that the sentence can be removed.
* Using %{buildroot} and %{optflags} vs
$RPM_BUILD_ROOT and $RPM_OPT_FLAGS
You use both %{_builddir} and $RPM_BUILD_ROOT . Choose one
(although this is very cosmetic).
Other thing are all okay.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list