[Bug 218172] Review Request: gnome-chemistry-utils - A set of chemical utilities
bugzilla at redhat.com
bugzilla at redhat.com
Sun Dec 3 15:46:26 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-chemistry-utils - A set of chemical utilities
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218172
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-12-03 10:46 EST -------
Well:
* BuildRequires: chemical-mime-data
Should this be 'BuildRequires' or 'Requires'?
* By the way, please remove unnecessary comments like:
------------------------------------------------
#mkdir -p -- $RPM_BUILD_ROOT%{_datadir}/mime/packages
------------------------------------------------
which are no longer used to make spec file more legible.
Note:
--add-category=X-Fedora
Well, FE packaging committee made a semi(?)-conclusion that
this should be removed because
* desktop-file-utils 0.11 does _NOT_ allow this so
* anyway this is deprecated and of no use
However, now rawhide is desktop-file-utils 0.12 and this again
_ALLOWS_ --add-category=X-Fedora ......
I think that '--add-category=X-Fedora' should be removed until
the argument that "--add-category=X-Fedora should be revived"
arises, however, it seems that this (--add-category=X-Fedora) is
okay for now??
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list