[Bug 219873] Review Request: kio_sword - lightweight Sword front-end for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kio_sword - lightweight Sword front-end for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219873


cgoorah at yahoo.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgoorah at yahoo.com.au




------- Additional Comments From cgoorah at yahoo.com.au  2006-12-17 05:01 EST -------
#1. Parallel make should be used
see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e

#2. gcc-c++ is among the exceptions, remove it from BR
see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-4cadce5e79d38a63cad3941de1dadc9d25d67d30

#3: is there a specific reason why you used:
[ -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] && %{__rm} -rf
--preserve-root $RPM_BUILD_ROOT
The buildroot is already defined.

#4: you should use
see: Scriptlets
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda

#5: during rpmbuild, I have:
/var/tmp/rpm-tmp.59067: line 30: kdeconfig: command not found
+ export KDEDIR=
+ KDEDIR=                                                                      
                                             

is it useful to use kdeconfig ?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.