[Bug 197302] Review Request: perl-Math-Round
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jul 3 20:20:59 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Math-Round
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197302
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-07-03 16:12 EST -------
BR: perl is not necessary (not a blocker).
No need to pass OPTIMIZE for a noarch package (not a blocker).
Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* source files match upstream:
ef35f988b32be4af3b3ccee131ece87f Math-Round-0.05.tar.gz
* latest version is being packaged.
O BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
perl(Math::Round) = 0.05
perl-Math-Round = 0.05-0.fc6
=
perl(:MODULE_COMPAT_5.8.8)
perl(Exporter)
perl(POSIX)
perl(strict)
perl(vars)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
nhimult..........ok 11
All tests successful.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list