[Bug 200064] Review Request: libpano12 : Library and tools for manipulating panoramic images
bugzilla at redhat.com
bugzilla at redhat.com
Tue Jul 25 09:47:46 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libpano12 : Library and tools for manipulating panoramic images
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200064
paul at all-the-johnsons.co.uk changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink at leemhuis.info |paul at all-the-johnsons.co.uk
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From paul at all-the-johnsons.co.uk 2006-07-25 05:38 EST -------
Okay, let's look at the spec
%define name_version %{name}-%{version}
This isn't needed. Just wipe it
BR gcc isn't needed
Not sure on the obsoletes/provides.
%configure --prefix - %configure is enough (unless the tarball decides to put it
somewhere odd). If it is available as a configure option, include --disable-static
%install
the two strip lines aren't required.
%package devel
Requires : should be %{version}-%{release}. It helps keep the devel files in
pace with the main package.
%description devel
The second paragraph isn't needed
%files
%{_bindir}/* - how many binaries does the package make? If they all start with
PT, then %{_bindir}/PT* and then one for the other one is a much better idea.
The same applies with the %{_libdir}
Does libpano12 not create it's own directory in %{_includedir} or is it again
just a couple of files?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list