[Bug 192574] Review Request: perl-Data-Structure-Util
bugzilla at redhat.com
bugzilla at redhat.com
Tue May 23 02:45:31 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Data-Structure-Util
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192574
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-05-22 22:37 EST -------
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* source files match upstream:
3cbec998cd7c55b1244b3f782569b552 Data-Structure-Util-0.11.tar.gz
3cbec998cd7c55b1244b3f782569b552 Data-Structure-Util-0.11.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
Util.so()(64bit)
perl(Data::Structure::Util) = 0.11
perl-Data-Structure-Util = 0.11-1.fc6
-
perl(:MODULE_COMPAT_5.8.8)
perl(AutoLoader)
perl(Data::Dumper)
perl(Digest::MD5)
perl(DynaLoader)
perl(Exporter)
perl(strict)
perl(vars)
perl(warnings::register)
* shared libraries are present, but internal to Perl so no need to call ldconfig.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
All tests successful.
Files=10, Tests=126, 0 wallclock secs ( 0.46 cusr + 0.18 csys = 0.64 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* no ninjas
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list