[Bug 253549] Review Request: TzClock - GTK+ Time Zone Clock
bugzilla at redhat.com
bugzilla at redhat.com
Mon Oct 1 03:43:40 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: TzClock - GTK+ Time Zone Clock
https://bugzilla.redhat.com/show_bug.cgi?id=253549
------- Additional Comments From rc040203 at freenet.de 2007-09-30 23:43 EST -------
(In reply to comment #15)
> (In reply to comment #14)
> From reading the manual and going on what you are saying the mistake is using
> *_CFLAGS at all.
Not quite. There are 2 small bugs interacting at the same time.
1) By using *_CFLAGS, you are _overriding_ automake's default CFLAGS's behavior.
What you intend to do is extending CFLAGS. To achieve this you need to add
$(AM_CFLAGS) to *_CFLAGS.
2) Passing preprocessor flags though *CFLAGS.
Autoconf and automake distinguish preprocessor flags from "<language>-FLAGS".
(CFLAGS, CXXFLAGS etc.)
> Because -D is a pre-processor command it should be included in
> the *_CPPFLAGS.
Right.
> The flags can be modified without causing problems so...
>
> TzClockCairo_CPPFLAGS = -DBUILDCAIRO
>
> ...is OK and follows the automake rules.
Right. In particular, it avoids interferring with CFLAGS ;)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list