[Bug 305551] Review Request: bluecurve-gtk-themes - Bluecurve GTK+ themes
bugzilla at redhat.com
bugzilla at redhat.com
Tue Sep 25 20:33:24 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: bluecurve-gtk-themes - Bluecurve GTK+ themes
https://bugzilla.redhat.com/show_bug.cgi?id=305551
notting at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|mclasen at redhat.com |notting at redhat.com
Flag| |fedora-review?
------- Additional Comments From notting at redhat.com 2007-09-25 16:33 EST -------
MUST items:
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name. - OK
- Spec has consistant macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - OK
- License field in spec matches - ***
Without any supporting information, the license tag should be 'GPL+'. If
something was added to the gtkrc files, I suppose it could be changed to a
different versions.
Then again, I wonder if gtkrc files are even enough of a work to be copyrightable.
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - ***
There's a duplicated comment.
- Sources match upstream md5sum: - N/A - no upstream yet
- Package needs ExcludeArch - N/A
- BuildRequires correct - OK
- Spec handles locales/find_lang - OK
- Package has %defattr and permissions on files is good. - OK
- Package has a correct %clean section. - OK
- Package has correct buildroot -OK
- Package is code or permissible content. - OK
- Packages %doc files don't affect runtime. - OK
- Package compiles and builds on at least one arch. - OK
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates. - OK
- No rpmlint output. - ***
bluecurve-gtk-themes.src: W: invalid-license GPL
See above.
bluecurve-gtk-themes.noarch: E: zero-length
/usr/share/doc/bluecurve-gtk-themes-1.0.0/ChangeLog
bluecurve-gtk-themes.noarch: E: zero-length
/usr/share/doc/bluecurve-gtk-themes-1.0.0/NEWS
bluecurve-gtk-themes.noarch: E: zero-length
/usr/share/doc/bluecurve-gtk-themes-1.0.0/README
Can remove.
bluecurve-gtk-themes.noarch: E: description-line-too-long This package contains
a collection of GTK+ themes that use the bluecurve engine.
You could word wrap this.
- final provides and requires are sane: - ***
Could probably remove the explicit gtk2 require since the engine will pull it in
, but... shrug.
SHOULD Items:
- Should build in mock. - OK
- Should build on all supported archs - OK
- Should function as described. - seems to work
- Should have dist tag - OK
Fix the license tag, mainly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list