[Bug 426867] Review Request: scala - Hybrid functional/object-oriented language
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jan 14 17:44:11 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: scala - Hybrid functional/object-oriented language
https://bugzilla.redhat.com/show_bug.cgi?id=426867
mtasaka at ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2008-01-14 12:44 EST -------
For 2.6.1-6:
A. General packaging issues on spec file.
A-1: Description stage:
* Disttag
- Please consider to use %?_dist tag.
http://fedoraproject.org/wiki/Packaging/DistTag
? Some questions for Requires
- For vim-scala, is it sufficient to require only vim-common?
- For XXX-scala subpackages (like emacs-scala), don' they need
scala package?
A-2: %prep, %build, %install stage
* Timestamps
http://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
- When using "cp" or "install" commands, please add "-p" option
to keep timestamps.
A-3: %files
* Directory ownership issue
- There are many directories which are not owned by any
packages.
--------------------------------------------------------------------
[tasaka1 at localhost ~]$ LANG=C rpm -qf /usr/share/scala/lib/scala-compiler.jar
scala-2.6.1-6
[tasaka1 at localhost ~]$ LANG=C rpm -qf /usr/share/scala/lib/
file /usr/share/scala/lib is not owned by any package
--------------------------------------------------------------------
Please make it sure that all directories which are created
when installing scala related packages are correctly owned by
scala related packages.
Note: When you write
--------------------------------------------------------------------
%files
%{_datadir}/scala/lib/
--------------------------------------------------------------------
This contains the directory %_datadir/scala/lib itself and all
files/directories/etc under %_datadir/scala/lib.
* gtksourceview2-scala
- For what purpose does this subpackage exist? This subpackage
contains no files.
B. rpmlint
--------------------------------------------------------------------
emacs-scala-el.noarch: W: no-documentation
enscript-scala.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/enscript-scala-2.6.1/README
gtksourceview2-scala.noarch: W: no-documentation
scala.noarch: W: symlink-should-be-relative
/usr/share/scala/lib/scala-compiler.jar /usr/share/java/scala/scala-compiler.jar
scala.noarch: W: symlink-should-be-relative
/usr/share/scala/lib/scala-partest.jar /usr/share/java/scala/scala-partest.jar
scala.noarch: W: symlink-should-be-relative /usr/share/scala/lib/scala-dbc.jar
/usr/share/java/scala/scala-dbc.jar
scala.noarch: W: symlink-should-be-relative
/usr/share/scala/lib/scala-library.jar /usr/share/java/scala/scala-library.jar
scala.noarch: W: class-path-in-manifest
/usr/share/java/scala/scala-partest-2.6.1.jar
scala.noarch: W: class-path-in-manifest /usr/share/java/scala/scala-dbc-2.6.1.jar
scala.noarch: W: class-path-in-manifest
/usr/share/java/scala/scala-compiler-2.6.1.jar
scala-devel.noarch: W: no-documentation
scala-devel.noarch: W: conffile-without-noreplace-flag /etc/ant.d/scala
scala-examples.noarch: W: no-documentation
--------------------------------------------------------------------
Summary:
* wrong-file-end-of-line-encoding
/usr/share/doc/enscript-scala-2.6.1/README contains Window-type
end-of-line encoding. Please fix this by "sed -i 's|\r||'" or
dos2unix.
* symlink-should-be-relative
Due to chroot issue and so, we request all symlinks should be relative,
not absolute.
* class-path-in-manifest
---------------------------------------------------------------------
[tasaka1 at localhost ~]$ rpmlint -I class-path-in-manifest
class-path-in-manifest :
The META-INF/MANIFEST file in the jar contains a hardcoded Class-Path.
These entries do not work with older Java versions and even if they do work,
they are inflexible and usually cause nasty surprises.
---------------------------------------------------------------------
Well, I am not familiar with Java and I am not sure if you should
fix this warning....
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list