[Bug 428780] Review Request: perl-MasonX-Request-WithApacheSession - Integrates Apache::Session into Mason
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jan 16 00:32:19 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-MasonX-Request-WithApacheSession - Integrates Apache::Session into Mason
https://bugzilla.redhat.com/show_bug.cgi?id=428780
------- Additional Comments From tibbs at math.uh.edu 2008-01-15 19:32 EST -------
This one build OK and rpmlint is silent.
I find it odd that there's no %check section even though there are tests. Did
you remove it, or did cpanspec not include it for some reason? I added
%check
./Build test verbose=1
and dependencies on perl(File::Find::Rule) and perl(Test::Pod) and the tests failed:
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
t/01-basic.t 1 256 12 1 8.33% 11
t/03-multi.t 1 256 7 1 14.29% 4
Failed 2/3 test scripts, 33.33% okay. 2/21 subtests failed, 90.48% okay.
You should investigate why these tests are failing and try to understand the
impact of the failures. I looked at the CPAN testing report and see that other
testers have seen the same test failures.
Checklist:
* source files match upstream:
30b0e6acb71ec790a8adbbec065f96093a7537233fb8c401491ac2e86df4484c
MasonX-Request-WithApacheSession-0.30.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
perl(MasonX::Request::WithApacheSession) = 0.30
perl(MasonX::Request::WithMultiSession)
perl-MasonX-Request-WithApacheSession = 0.30-1.fc9
=
perl >= 0:5.005
perl(:MODULE_COMPAT_5.8.8)
perl(Apache::Session::Wrapper) >= 0.13
perl(Digest::SHA1)
perl(HTML::Mason) >= 1.16
perl(HTML::Mason::Exceptions)
perl(HTML::Mason::Request)
perl(Params::Validate)
perl(Time::HiRes)
perl(base)
perl(strict)
perl(vars)
X %check is not present even though a test suite is in the tarball. You need to
run upstream test suites whenever possible.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list