[Bug 469273] Review Request: quickfix - development library for FIX based applications
bugzilla at redhat.com
bugzilla at redhat.com
Sun Nov 9 18:56:20 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469273
--- Comment #14 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2008-11-09 13:56:19 EDT ---
For -4:
* BuildRequires
- build.log shows:
------------------------------------------------------
348 checking for boost::pool_allocator...
349 no
350 checking for boost::fast_pool_allocator...
351 no
------------------------------------------------------
I guess "BuildRequires: boost-devel" must be added
!!!!
By the way, would you consider to build
mysql/postgresql/python/ruby/java bindings?
* Requires for -devel subpackage
- A package which contains pkgconfig .pc file must have
"Requires: pkgconfig":
https://fedoraproject.org/wiki/Packaging/ReviewGuidelines
- Also installed quickfix.pc contains:
------------------------------------------------------
Requires: libxml-2.0
------------------------------------------------------
This means that -devel subpackage must have
"Requires: libxml2-devel".
* 64 bits architecture issue
- quickfix.pc.in contains
-------------------------------------------------------
3 libdir=@prefix@/lib
-------------------------------------------------------
@prefix@/lib is expanded as /usr/lib (on Fedora) even on
64 bits architecture, while on those machine this must
be /usr/lib64.
Usually replacing this with libdir=@libdir@ will fix
this issue
* Use of %makeinstall
- Please write comments before calling %makeinstall that
this tarball does not support "make install DESTDIR=foo".
* Directory ownership issue
- Currently the directory %_datadir/%name itself is not
owned by any packages.
Note that
-------------------------------------------------------
%files
%{_datadir}/%{name}/
-------------------------------------------------------
contains the directory %_datadir/%name itself and all
files/directories/etc under %_datadir/%name.
ref:
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
* libtool .la files
- Usually libtool .la files must be removed.
https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries
* %changelog format
- For Fedora CVS usage I recomment to add one line between
every %changelog entry like:
--------------------------------------------------------
* Sat Nov 08 2008 Hayden James - 1.12.4-4
- Changed license to ASL 1.1 and BSD with advertising. Improved spec file to
better conform
* Sat Nov 07 2008 Hayden James - 1.12.4-3
- Changed license to ASL 1.1
* Sat Nov 03 2008 Hayden James - 1.12.4-2
- Changed license to BSD
--------------------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list