[Bug 460779] Review Request: nekovm - Neko embedded scripting language and virtual machine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460779





--- Comment #4 from Dan Horák <dan at danny.cz>  2008-09-02 12:14:09 EDT ---
formal review is here, see notes at the end

OK source files match upstream:
     cf2d1ebcb483fe88abb263fe276015f710a751bb  neko-1.7.1.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
?? rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
BAD no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
BAD no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- use --keepdate when running dos2unix to preserve the timestamps for the files
- shared library is added, but ldconfig scriptlets are missing
- rpmlint complains
nekovm.src:102: E: hardcoded-library-path in %{_prefix}/lib/neko
nekovm.src:109: E: hardcoded-library-path in %{_prefix}/lib
nekovm.src:110: E: hardcoded-library-path in %{_prefix}/lib/*.so
nekovm.src:127: E: hardcoded-library-path in %{_prefix}/lib/neko/
 - I think these will create a multilib issue together with shared libneko.so
in the main package
 - what is the purpose of the *.ndll? runtime libs for nekovm based apps?

nekovm.x86_64: W: no-soname /usr/lib64/libneko.so
 - result of not-so-right linking command

I think you need to split the package to
main - %{_bindir} + /usr/lib/neko
libs - %{_libdir}
devel - %{_includedir}

- I think that more appropriate Group for the main package is
Development/Languages, the -libs should go into System Environment/Libraries
and -devel should be in Development/Libraries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.