[Bug 461392] Review Request: perl-Tie-ToObject - Tie to an existing object

bugzilla at redhat.com bugzilla at redhat.com
Sun Sep 7 13:04:32 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461392


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com




--- Comment #2 from Parag AN(पराग) <panemade at gmail.com>  2008-09-07 09:04:30 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=811495
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
b4f434992c286d531f26893c78541456  Tie-ToObject-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=10,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.05 cusr  0.01
csys =  0.07 CPU)
+ Package perl-Tie-ToObject-0.03-1.fc10 =>
Provides:
 perl(Tie::ToObject) = 0.03
Requires: 
perl(Carp) perl(Scalar::Util) perl(strict) perl(vars)


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list