[Bug 450371] Review Request: sigen - Strategy/RPG game engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450371





--- Comment #39 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-08 14:07:42 EDT ---
Well, for sigen 0.0.2-0.16.svn

* Summary, description
  - Usually "The Sigma Game Engine is" is redundant for summary
  - rpmlint warns:
--------------------------------------------------------
sigen.i386: E: description-line-too-long The Sigma Game Engine is an
RPG/Strategy game engine. The following is provided:
--------------------------------------------------------
    %description lines should have less than 80 characters.

* make build log more verbose
  - Well, maybe I forgot to mention this before (umm), however
    current build.log shows:
--------------------------------------------------------
  1766  Building CXX object sigscript/CMakeFiles/sigscript.dir/SigmodWrapper.o
  1767  [ 51%] 
  1768  Building CXX object sigscript/CMakeFiles/sigscript.dir/SkinWrapper.o
  1769  [ 51%] 
  1770  Building CXX object sigscript/CMakeFiles/sigscript.dir/SoundWrapper.o
  1771  [ 51%] 
  1772  Building CXX object sigscript/CMakeFiles/sigscript.dir/SpeciesWrapper.o
  1773  [ 52%] 
  1774  Building CXX object
sigscript/CMakeFiles/sigscript.dir/SpeciesAbilityWrapper.o
--------------------------------------------------------
     which is not useful, for example we cannot check from this log
     if Fedora specific compilation flags are honored correctly.
     Perhaps as this uses cmake "make VERBOSE=1 %{_smp_mflags}" will
     show more verbose logs. Please refer to:
     https://fedoraproject.org/wiki/Packaging/cmake

* %doc
  - Files under %docdir are automatically marked as %doc

* Directory ownership issue
  - The directory %{_docdir}/%{name}-%{version}/ is not owned by any packages
    (please refer to:
     https://fedoraproject.org/wiki/PackagingDrafts/UnownedDirectories )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.