[Bug 225626] Merge Review: brltty

Tue Sep 9 14:24:29 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225626

Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |skasal at redhat.com

--- Comment #3 from Jon Ciesla <limb at jcomserv.net>  2008-09-09 10:24:27 EDT ---
Adding current maintainer to CC.

Current rawhide srpm now builds.

rpmlint on srpm:

brltty.src:124: W: rpm-buildroot-usage %build %configure
--with-install-root="${RPM_BUILD_ROOT}" --with-braille-driver=-tt
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.

brltty.src:182: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

brltty.src:185: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

brltty.src:304: W: macro-in-%changelog configure
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted.  Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.

brltty.src: W: summary-ended-with-dot Braille display driver for Linux/Unix.
Summary ends with a dot.

Should all be fixed or commented in spec.

rpmlint on rpms:

brlapi.i386: W: file-not-utf8 /usr/share/doc/brlapi-0.5.1/BrlAPI.txt
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile for example using iconv(1).

brlapi.i386: W: file-not-utf8 /usr/share/doc/brlapi-0.5.1/BrlAPI.sgml
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile for example using iconv(1).

Fix.

brlapi.i386: E: library-without-ldconfig-postin /usr/lib/libbrlapi.so.0.5.1
This package contains a library and provides no %post scriptlet containing a
call to ldconfig.

brlapi.i386: E: library-without-ldconfig-postun /usr/lib/libbrlapi.so.0.5.1
This package contains a library and provides no %postun scriptlet containing a
call to ldconfig.

Fix, or explain in spec why this is unneccesary.

brlapi.i386: W: summary-ended-with-dot Appliation Programming Interface for
BRLTTY.
Summary ends with a dot.

Fix.

brlapi-devel.i386: W: summary-ended-with-dot Headers, static archive, and
documentation for BrlAPI.
Summary ends with a dot.

Fix.

brlapi-java.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Fix or explain in spec.

brlapi-java.i386: W: summary-ended-with-dot Java binding for BrlAPI.
Summary ends with a dot.

Fix.

brltty.i386: W: spurious-executable-perm
/usr/share/doc/brltty-3.9/Bootdisks/rhmkroot
brltty.i386: W: spurious-executable-perm
/usr/share/doc/brltty-3.9/Bootdisks/rhmkboot
brltty.i386: W: spurious-executable-perm /usr/share/doc/brltty-3.9/rhmkroot
brltty.i386: W: spurious-executable-perm
/usr/share/doc/brltty-3.9/Bootdisks/bp2cf
brltty.i386: W: spurious-executable-perm /usr/share/doc/brltty-3.9/rhmkboot
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/VideoBraille/README.it
brltty.i386: W: spurious-executable-perm
/usr/share/doc/brltty-3.9/Bootdisks/rhmkiso

The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

brltty.i386: W: non-conffile-in-etc /etc/brltty/*

Probably OK.

brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/TSI/README
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/MDV/README
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/Bootdisks/README.RedHat.fd
brltty.i386: W: file-not-utf8 /usr/share/doc/brltty-3.9/ChangeLog
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/Voyager/README
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/LogText/README
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/SpeechDrivers/ExternalSpeech/README
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/LogText/help.txt
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/VisioBraille/README
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/BrailleLite/README
brltty.i386: W: file-not-utf8
/usr/share/doc/brltty-3.9/BrailleDrivers/VisioBraille/help.txt
brltty.i386: W: file-not-utf8 /usr/share/doc/brltty-3.9/README

The character encoding of this file is not UTF-8.  Consider converting it in
the specfile for example using iconv(1).

Fix.

brltty.i386: W: non-executable-in-bin /usr/bin/brltty-config 0644
A file is being installed in /usr/bin, but is not an executable. Be sure that
the file is an executable or that it has executable permissions.

brltty.i386: W: devel-file-in-non-devel-package /usr/bin/brltty-config
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

brltty.i386: E: non-executable-script /usr/bin/brltty-config 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

Very unusual, should be corrected or documented.

brltty.i386: E: zero-length
/usr/share/doc/brltty-3.9/BrailleDrivers/Papenmeier/help.txt

No need to include this file.

brltty.i386: W: doc-file-dependency /usr/share/doc/brltty-3.9/Bootdisks/rhmkiso
/bin/bash
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts with executable bits set included in the package's documentation.

brltty.i386: W: dangerous-command-in-%post chmod
brltty-at-spi.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

brltty-at-spi.i386: W: summary-ended-with-dot AtSpi driver for BRLTTY.
Summary ends with a dot.

brltty-xw.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

brltty-xw.i386: W: summary-ended-with-dot XWindow driver for BRLTTY.
Summary ends with a dot.

python-brlapi.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

python-brlapi.i386: W: summary-ended-with-dot Python binding for BrlAPI.
Summary ends with a dot.

tcl-brlapi.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

tcl-brlapi.i386: W: summary-ended-with-dot Tcl binding for BrlAPI.
Summary ends with a dot.

Fix.

Mock build dies:

<snip>
configure.ac:1406:
bad expression in eval: brltty_help_prefix+0
autom4te: /usr/bin/m4 failed with exit status: 1
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.5bTMbp (%prep)
    Bad exit status from /var/tmp/rpm-tmp.5bTMbp (%prep)
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps
builddir/build/SPECS/brltty.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/mock/trace_decorator.py", line 70, in
trace
    result = func(*args, **kw)
  File "/usr/lib/python2.5/site-packages/mock/util.py", line 316, in do
    raise mock.exception.Error, ("Command failed. See logs for output.\n # %s"
% (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps
builddir/build/SPECS/brltty.spec']
LEAVE do --> EXCEPTION RAISED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.