[Bug 458346] Review Request: gflags - Library for commandline flag processing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458346





--- Comment #13 from Till Maas <opensource at till.name>  2008-09-10 11:40:20 EDT ---
[OK] rpmlint output: silent
{OK} Timestamps preserved with cp and install

Other issues from comment 3: OK

(In reply to comment #10)

> I have fixed the issues. I have disabled test suite because 2 out of 17 where
> failing on x86_64 on rawhide.

Did you report this to upstream? Are you sure that the test suite is buggy and
not the package itself, i.e. does it really work as intended on x86_64? There
is also a binary testsuite that can be run with "make test", but it uses
unsecure tempfiles: It always uses the same directories in /tmp to perform the
test, which can maybe exploited.

I consider the testsuite issues not to be a blocker, therefore this package is
now  APPROVED. Nevertheless, please try to get upstream to make the testsuite
workable within Fedora builds.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.