[Bug 226531] Merge Review: vnc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226531


Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb at jcomserv.net
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net




--- Comment #1 from Jon Ciesla <limb at jcomserv.net>  2008-09-17 13:32:06 EDT ---
Build of rawhide SRPM on F-9 fails:

In file included from glxdriswrast.c:39:
/usr/include/GL/internal/dri_interface.h:43:17: error: drm.h: No such file or
directory
In file included from glxdriswrast.c:39:
/usr/include/GL/internal/dri_interface.h:278: error: expected declaration
specifiers or '...' before 'drm_clip_rect_t'
/usr/include/GL/internal/dri_interface.h:280: error: expected declaration
specifiers or '...' before 'drm_clip_rect_t'
/usr/include/GL/internal/dri_interface.h:334: error: expected declaration
specifiers or '...' before 'drm_clip_rect_t'
/usr/include/GL/internal/dri_interface.h:596: error: expected declaration
specifiers or '...' before 'drm_drawable_t'
/usr/include/GL/internal/dri_interface.h:604: error: expected declaration
specifiers or '...' before 'drm_context_t'
make[1]: *** [glxdriswrast.lo] Error 1
make[1]: Leaving directory
`/home/limb/rpmbuild/BUILD/vnc-4_1_2-unixsrc/unix/xorg-x11-server-source/glx'
make: *** [all-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.69026 (%build)


License tag should be GPLv2+.

Upstream Source is 404.

There are 36 patches, with no notes as to upstream status.

Can't check BuildRequires, or run rpmlint on RPMS, see above.

rpmlint on spec:

vnc.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 128)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

Fix.

Other than the above, full review is good, no other blockers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.