[Bug 461849] Review Request: garmintools - Communication tools for Garmin devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461849





--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2008-09-17 14:19:36 EDT ---
(In reply to comment #1)

Thanks for your input and comments

> 1. In the files section, your using '%{_libdir}/*', which is causing your main
> rpm to pull in the debuginfo.  What you need to do is explicitly list your
> shared libs, that way you'll get a seperate rpm with the debuginfo.  You should
> use something like '%{_libdir}/libgarmin*.so.*'.

fixed

> 2. libtool archives should not be included.  You should add the following in
> the %install section after your 'make install':
> 
> find %{buildroot} -name '*.la' -exec rm -f {} ';'

fixed

> 2. Static libs -  currently your building them, and I'm pretty sure that's not
> necessary.  To prevent this, you can add '--enable-static=no' to your configure
> line in the %build section.  For more info refer to the static libs section in
> the packaging guidelines.
> http://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries

fixed

> 3. missing -devel subpackage.  the package headers in the %{_includedir} and
> the *.so should be included  in this sub package.
> 
> 4. After a quick look the source it looks like this package should have a
> license tag of 'GPLv2+'

fixed

I hope that I fixed all points in the right way because I'm still in the
'learn-how-to-make-packages' phase.  Unfortunately this packages depends on
'libgarmin' that is no available in Fedora.  So I have to pack 'libgarmin'
first and then we can go on with this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.