[Bug 454102] Review Request: perl-Catalyst-Model-XMLRPC - XMLRPC model class for Catalyst

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 23 09:28:29 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454102





--- Comment #8 from Miroslav Suchy <msuchy at redhat.com>  2008-09-23 05:28:28 EDT ---
You point to wrong src.rpm (-1 release) so I tried to download 
http://fedora.biggerontheinside.net/review/perl-Catalyst-Model-XMLRPC-0.04-2.fc9.src.rpm
and it was there. So I'm using this in this comments.

The [2] is ok. You are now using Patch0:

But the [1] is still problem, you just mask the problem so rpmlint do not
detect it. I do not understand why do you have this part there at all:
# note we first filter out the bits in _docdir...
cat << \EOF > %{name}-prov
#!/bin/sh
FOO=`perl -p -e 's|%{broot}%{_docdir}/%{name}-%{version}\S+||'`
%{__perl_provides} $FOO
EOF

%define __perl_provides
%{_builddir}/Catalyst-Model-XMLRPC-%{version}/%{name}-prov
chmod +x %{__perl_provides}

If I delete this lines and this one from %files:
%doc Changes README t/
will replace with
%doc Changes README
I got the same output (with same provides).

You should not install content of t/ dir anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list