[Bug 459675] Review Request: python-sybase - new package request

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459675


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-27 13:13:22 EDT ---
Some notes:

* License tag
  - We do not allow BSD"-style" license tag, either "BSD" or "BSD with
advertising", or
    if not BSD, something else.
    https://fedoraproject.org/wiki/Licensing
    In this package the license tag should be "BSD".

* BuildRequires
  - Without "BuildRequies: python-devel python-setuptools", your srpm won't
build
    (and fixes for 64 bits architecture is needed, see below)

* Requires
  - "Requires: freetds" is not needed. rpmbuild checks library related
dependencies
     and adds them to the rebuilt binary rpms.

* Macros
  - Use macros for common directories:
    https://fedoraproject.org/wiki/Packaging/RPMMacros
    For example, /usr must be %{_prefix}

* Directory description
  * On 64 bits architecture site related files must be installed under 
    /usr/lib64/python2.5/site-packages and your spec file won't work on 64 bits
architecture.
  * Also %files entry
------------------------------------------------------------------
%files
%{_libdir}/*
------------------------------------------------------------------
    cannot be allowed because of some reasons.
    - This contains many subdirectories (directories themselves, not files)
which 
      are already listed in filesystem rpm and should not be listed in this
      package:
     
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
    - This contains %{_libdir}/debug, which must be used only for -debuginfo
rpm

    For python rpm please check
    https://fedoraproject.org/wiki/Packaging/Python#System_Architecture
    Especially, please check %{python_sitearch} macro or so.

    I guess it is better you use a skeleton spec file for python modules
    and modify it. You can create such skeleton spec file by
--------------------------------------------------------------
    $ rpmdev-newspec -t python python-sybase
--------------------------------------------------------------
    (rpmdev-newspec is in rpmdevtools rpm).

* %changelog
  - Please check %changelog format described in:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.