[Bug 463400] Review Request: xmmsctrl - command line control utility for xmms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463400


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-27 14:43:18 EDT ---
Some notes:

* Disttag
  - Please consider to use %{?dist} tag for release number:
    https://fedoraproject.org/wiki/Packaging/DistTag

* ExclusiveArch
  - Would you explain why these ExclusiveArch is needed?

* Optflags
  - Build log shows that Fedora specific compilation flags
    are not honored correctly. As the result debuginfo rpm is
    currently not useful.
    You can check what optflags are used by
    $ rpm --eval %optflags
    ref:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

* Parallel make
  - Support parallel make if possible:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
    If this package does not support parallel make, write as such
    in the spec file as comments.

* File permission
  - Usually normal (non-executable) files should have 0644 permission
    (not 0444).

* %defattr
  - We recommend %defattr(-,root,root,-)

* Comment in macros
---------------------------------------------------
#%defattr(0755,root,root)
---------------------------------------------------
  - In comments and %changelog, use %% (instead of %) so that macros
    won't be expanded in comments or %changelog.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.