[Bug 463400] Review Request: xmmsctrl - command line control utility for xmms

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463400


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841                      |
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-28 09:32:57 EDT ---
(In reply to comment #2)
> Thanks for the review. 
> I fixed everything you said. The ExclusiveArch isn't needed, I took it off. One
> little question about the optflags: I added $RPM_OPT_FLAGS to the 'make'. Is
> that enough?

 - I guess fixing (specifying) "WARN" or "CC" rather than "CFLAGS" is simpler,
like:
   make %{?_smp_mflags} WARN="${RPM_OPT_FLAGS}"

* Other things are okay.
* New comtributor who wants to get sponsored are requested to either
  - submit another review request
  - or do a pre-review of other person's review request
  to "show that you have an understanding of the process and of 
  the packaging guidelines" as is described on :
  http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

  For your case you have another review reques (bug 463996), which seems
  in good shape.

---------------------------------------------------------------------
    This package (xmmsctrl) is APPROVED by mtasaka
---------------------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Install the Client Tools (Koji)". Now I am sponsoring you.

If you want to import this package into Fedora 8/9, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Removing NEEDSPONSOR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.