[Bug 463922] Review Request: ifstat - Interface statistics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463922





--- Comment #4 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-09-29 18:01:12 EDT ---
I am not sure that the destdir patch is needed, I'll try to check tomorrow.

And no, you should NOT disable building the debuginfo package. Exactly the
opposite, you should make sure it contains useful info (i.e. the debug symbols
stripped from the binaries; rpmbuild will do it for you automatically if you
create a correct spec and you take care to not strip the generated binaries.)

As of the file-not-utf8 one, that is easy. Just use iconv to convert it.
Something similar to
 iconv README -f ISO8859-1 -o README.utf8
 touch -r README  README.utf8
 mv README.utf8 README
will convert the file and preserve the timestamp.
BTW, you should use 
%{__make} install DESTDIR=$RPM_BUILD_ROOT CFLAGS="$RPM_OPT_FLAGS"
INSTALL="install -p" 
in order to preserve the timestamps of the files. Or , alternatively, you could
add the "-p" parameter to the install commands from your patch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.