[Bug 497665] Review Request: perl-Crypt-CipherSaber - Perl module implementing CipherSaber encryption
bugzilla at redhat.com
bugzilla at redhat.com
Sun Apr 26 09:12:09 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Iain Arnell <iarnell at gmail.com> changed:
What |Removed |Added
CC| |iarnell at gmail.com
AssignedTo|nobody at fedoraproject.org |iarnell at gmail.com
--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2009-04-26 05:12:08 EDT ---
+ source files match upstream.
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
+ package installs properly.
+ rpmlint has no complaints:
perl-Crypt-CipherSaber.noarch: I: checking
perl-Crypt-CipherSaber.src: I: checking
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
perl(Crypt::CipherSaber) = 1.00
perl-Crypt-CipherSaber = 1.00-1.fc12
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
+ %check is present and all tests pass (with the caveat about
All tests successful.
Files=10, Tests=32, 1 wallclock secs ( 0.07 usr 0.02 sys + 0.59 cusr 0.10
csys = 0.78 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review