[Bug 475017] Review Request: l2fprod-common - In JavaSE missing Swing components, inspired from modern user interfaces
bugzilla at redhat.com
bugzilla at redhat.com
Wed Apr 29 16:57:43 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475017
Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #20 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2009-04-29 12:57:41 EDT ---
Well,
- For the line "javadoc -classpath ..." I recommend to use
find - xargs also here, like:
------------------------------------------------------------------
find src/java -name '*.java' -print 0 \
xargs -0 javadoc -classpath \
`build-classpath nachocalendar jcalendar` -d doc
------------------------------------------------------------------
- I recommend to remove unneeded comments because it makes
spec file less readable.
- Please make main package own %_javadir/%name
Please fix the issues above before importing.
-----------------------------------------------------------
This package (l2fprod-common) is APPROVED by mtasaka
-----------------------------------------------------------
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list