[Bug 225286] Merge Review: aspell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225286


Roman Rakus <rrakus at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(varekova at redhat.c
                   |                            |om)




--- Comment #19 from Roman Rakus <rrakus at redhat.com>  2009-12-01 03:59:48 EDT ---
# MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT). [16]
ok

# MUST: Each package must consistently use macros. [17]
ok

# MUST: The package must contain code, or permissable content. [18]
ok

# MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [19]
ok

# MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [19]
ok

# MUST: Header files must be in a -devel package. [20]
ok

# MUST: Static libraries must be in a -static package. [21]
ok

# MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability). [22]
ok

# MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. [20]
ok

# MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} [23]
ok

# MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[21]
ok

# MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[24]
ok

# MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. [25]
ok

# MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). [26]
ok

# MUST: All filenames in rpm packages must be valid UTF-8. [27]
ok
----
Summary:
Fix rpmlint errors.
Check licences:
- Many times LGPL (v2.1) (with incorrect FSF address)
- aspell-0.60.6/modules/speller/default/affix.cpp: BSD (2 clause) 
- aspell-0.60.6/misc/po-filter.c: GPL (v2 or later) (with incorrect FSF
address) 
- aspell-0.60.6/ltmain.sh: GPL (v2 or later) 
- aspell-0.60.6/myspell/munch.c: BSD (2 clause) 
Remove using %{_datadir}/locale/*.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.