[Bug 226649] Merge Review: xorg-x11-xbitmaps
bugzilla at redhat.com
bugzilla at redhat.com
Sat Dec 19 21:52:58 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226649
Thomas Spura <tomspur at fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomspur at fedoraproject.org
--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2009-12-19 16:52:56 EDT ---
$ rpmlint xorg-x11-xbitmaps.spec xorg-x11-xbitmaps-1.1.0-1.fc13.src.rpm
noarch/xorg-x11-xbitmaps-1.1.0-1.fc13.noarch.rpm
xorg-x11-xbitmaps.spec:17: W: unversioned-explicit-provides xbitmaps
xorg-x11-xbitmaps.spec:18: W: unversioned-explicit-provides xbitmaps-devel
xorg-x11-xbitmaps.src:17: W: unversioned-explicit-provides xbitmaps
xorg-x11-xbitmaps.src:18: W: unversioned-explicit-provides xbitmaps-devel
xorg-x11-xbitmaps.noarch: W: no-documentation
xorg-x11-xbitmaps.noarch: W: devel-file-in-non-devel-package
/usr/share/pkgconfig/xbitmaps.pc
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
- There is ChangeLog and COPYING for %doc.
- Isn't %configure and --libdir a bit hacky?
You assume, that the latest used --libdir is used in the configure. Don't
know
if that's always the case. Hope so ;)
- Could the provides xbitmaps deleted, if bitmaps requires xorg-x11-xbitmaps
and not xbitmaps anymore?
AFAIK this is the only programm which uses 'xbitmaps'
$ repoquery --whatrequires xbitmaps
bitmap-0:1.0.3-6.fc12.x86_64
- parallel make is not really needed, because nothing is build in make, but
could you use 'make %{?_smp_mflags}' anyway?
- from https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files
requires: pkgconfig is missing
Rest looks ok.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the package-review
mailing list