[Bug 549496] Review Request: bakefile - is cross-platform, cross-compiler native makefiles generator

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 21 20:54:14 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549496


Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no




--- Comment #1 from Terje Røsten <terjeros at phys.ntnu.no>  2009-12-21 15:54:13 EDT ---
Some random comments.

a) Is summary a bit strange? Drop the leading verb?

b) Useless line: %doc. Is there more info available in the package?

c) I am favor of more explicit %files section,  %{_libdir}/* 
   can pick up random stuff.

d) The source url is not correct, just drop %{name} macro here.

e) %{_mandir}/man1/bakefil*.gz change to %{_mandir}/man1/bakefil*
 (compression might change to e.g. xz)

f) commas in buildreq/req is just noise

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list