[Bug 479951] Review Request: iniparser - a library for parsing ini-style files
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jan 14 16:57:27 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=479951
Jochen Schmitt <jochen at herr-schmitt.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jochen at herr-schmitt.de
--- Comment #1 from Jochen Schmitt <jochen at herr-schmitt.de> 2009-01-14 11:57:26 EDT ---
Good:
+ Package name fits with nameing guidelines.
+ Source file could downloaded with spectool
+ Tar ball in package fits with upstreams
(md5sum: 89b7d97b9fb24ce4c31743cc4d13ce44)
+ Package contains valid Group
+ Package contains valid license tag
+ License from the license tag is a valid OSS license
+ Consistently usage of rpm macros
+ Package contains varbatin copy of the license text
+ Rpmlint is quite on source rpm
+ Rpmlint is quite on binary rpm
+ Rpmlint is quite on intalled rpm
+ Rpmlint is quite on debuginfo package, Debuginfo package
contains valid source files.
+ Package contains scriptlets for ldconfig
+ Package contains a devel subpackage
+ devel subpackage contains Requires on main package
+ Files contains no files belongs to other packages
+ Files have proper file perms
+ %doc stanza is small, so we need no separate doc subpackage
+ Package builds fine on koji, if you are add '-fPIC'
+ Package contains proper %changelog stanza
+ Local install of the package works fine
+ Local uninstall of the package works fine
Bad:
- Local build failed, Please add '-fPIC' compilerflag if you want to create a
dynamic library
- Please use install for installing the files of your package
- Please notify upstream, that each source file should have a copyright notice
- Please remove %check stanza, if you don't have the testsuite which should be
executing during the build
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list