[Bug 492715] Review Request: KRadio4 - V4L/V4L2-Radio Application for KDE4

bugzilla at redhat.com bugzilla at redhat.com
Fri May 29 11:33:27 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492715





--- Comment #20 from Paulo Roma Cavalcanti <promac at gmail.com>  2009-05-29 07:33:26 EDT ---
(In reply to comment #19)
> - I thin that you do not need this:
> =============================================================
> update-mime-database %{_kde4_datadir}/mime &> /dev/null || :
> =============================================================
> 
> This is neded only if application drops an XML file in
> %{_datadir}/mime/packages.

I will remove it.

> 
> Please, can you explain this:
> =============================================
> unset QTINC QTLIB QTPATH_LRELEASE QMAKESPEC
> export QT4DIR=%{_libdir}/qt4
> export QTDIR=$QT4DIR
> PATH=$QT4DIR/bin:$PATH ; export PATH
> =============================================
> 
> Do we need this?  

If we build with mock, the answer is no, we do not need this.
However, If a user try to rebuild the package, he could have set 
in his environment the variables for QT3, and the build will fail.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list