[Bug 527241] Review Request: libvtemm - C++ bindings for vte

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527241





--- Comment #3 from Krzesimir Nowak <qdlacz at gmail.com>  2009-11-04 10:47:19 EDT ---
(In reply to comment #2)
> * The package naming guidelines answer your question:
> 
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Spec_file_name
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#MultiplePackages
> 
> 

Ok. I renamed package to libvtemm.

> > Having API docs without devel package does not make much sense.
> 
> Sure it does!  One can read documentation and evaluate an API without needing
> to install -devel package dependency-chains. One could even create a
> Documentation spin, which would not be possible with superfluous unresolvable
> dependencies on -devel packages.
> 

Oh, but I wonder if anyone ever complained that gtkmm/glibmm/othermm-docs
package depend on -devel one. But what you say has much sense, so I removed the
dependency.

> 
> > # Documentation is moved from its original directory to one
> > owned by gtk-doc.
> > # Why it is done is unclear for me.
> > Requires:       gtk-doc
> 
> Um, what? That comment caused some head-scratching. It's *you* who moves the
> documentation during %install. As why you do that, one reason for moving it
> from %_docdir to gtk-doc's place is to make it available to the "devhelp" tool.
> 

I move it, because I noticed that in gtkmm/glibmm Fedora maintainer did it, so
at first I wanted to be consistent.

Devhelp argument is false - I made a scratch build[1] of libvtemm-0.20.6 (so I
could install it on my Fedora 11) and installed only -docs package, which had
documentation in %{_docdir}/libvtemm-1.2 and .devhelp2 file in
%{_datadir}/devhelp/books/libvtemm-1.2/. After installation in devhelp's book
list libvtemm appeared. So there are two ways of installing documentation:

1. let the documentation lie, where developer of library (me) decided - this
adds devhelp dependency to -docs package.
2. move documentation to %{_datadir}/gtk-doc, like in gtkmm/glibmm/othermm
Fedora packages - this adds probably gtk-doc dependency to -docs package.
(Probably, because in gtkmm/glibmm/othermm-docs such dependency doesn't exist.
The same in in for example glib2-devel, which puts documentation into gtk-doc
directory.)

> 
> > %install
> > rm -rf %{buildroot} docs-to-include
> > rm -rf %{buildroot}
> 
> The second one is redundant.  

That one I forgot to remove. :)

new spec: http://krnowak.fedorapeople.org/libvtemm.spec
new srpm: http://krnowak.fedorapeople.org/libvtemm-0.22.1-2.fc11.src.rpm
new koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1787913
new rpmlint outputs:

libvtemm.spec:
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

libvtemm-0.22.1-2.fc11.src.rpm:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

libvtemm-0.22.1-2.fc12.i686.rpm:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

libvtemm-debuginfo-0.22.1-2.fc12.i686.rpm:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

libvtemm-devel-0.22.1-2.fc12.i686.rpm:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

libvtemm-docs-0.22.1-2.fc12.i686.rpm:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=1787855

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.