[Bug 540791] Review Request: rubygem-RubyInline - Write foreign code within your ruby code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=540791





--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-11-26 14:50:25 EDT ---
Some notes:

* BuildRequires
  - "BR: gcc" is redundant because gcc is always installed
    with mockbuild:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
    ( Well, I can guess why you added such explicit "BR: gcc" because
      actually "rake check" calls gcc while the rebuilt rpm itself
      is noarch, however still I think "BR: gcc" is redundant )

! example scripts
-------------------------------------------------------
# Organize this in a more typical way
mkdir %{buildroot}%{geminstdir}/examples
mv %{buildroot}%{geminstdir}/*.rb %{buildroot}%{geminstdir}/examples/
-------------------------------------------------------
  - I don't object to this, however I am not sure this is
    really needed or not, as 
    * these scripts are packaged into -doc subpackage so people 
      will easily find that these scripts are examples or so.
    * Also $ gem contents --prefix RubyInline expects that these
      scripts are under %geminstdir.
      This is NOT a blocker, because we already delete or move files
      which are expected by $ gem contents, however for this
      case I don't strictly feel the necessity for moving these
      files.

    However again I don't object to this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.