[Bug 579375] Review Request: perl-CGI-PSGI - Enable your CGI.pm aware applications to adapt PSGI protocol

bugzilla at redhat.com bugzilla at redhat.com
Sun Apr 11 18:09:35 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579375

--- Comment #2 from Chris Weyl <cweyl at alumni.drew.edu> 2010-04-11 14:09:29 EDT ---
Looks good!

The usual suggestions w.r.t. PERL_INSTALL_ROOT and using
%{?perl_default_filter} apply.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2108548

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
c9a2cd4d5309ac45ffa690a0e340ac2f1f8d5f1c CGI-PSGI-0.10.tar.gz
c9a2cd4d5309ac45ffa690a0e340ac2f1f8d5f1c CGI-PSGI-0.10.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-CGI-PSGI-0.10-1.fc14.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-CGI-PSGI-0.10-1.fc14.noarch.rpm
perl(CGI::PSGI) = 0.10
perl-CGI-PSGI = 0.10-1.fc14
====> requires for perl-CGI-PSGI-0.10-1.fc14.noarch.rpm
perl >= 0:5.008_001
perl(base)  
perl(:MODULE_COMPAT_5.10.1)  
perl(strict)  

=====> perl-CGI-PSGI-0.10-1.fc14.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-CGI-PSGI-0.10-1.fc14.src.rpm
====> requires for perl-CGI-PSGI-0.10-1.fc14.src.rpm
perl  
perl(CGI)  
perl(ExtUtils::MakeMaker)  
perl(Test::More)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list