[Bug 510464] Review Request: gns3 - Graphical network simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510464

Caius 'kaio' Chance <cchance at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |cchance at redhat.com
         AssignedTo|nobody at fedoraproject.org    |cchance at redhat.com
               Flag|                            |fedora-review?

--- Comment #9 from Caius 'kaio' Chance <cchance at redhat.com> 2010-04-30 02:25:08 EDT ---
#  MUST: rpmlint must be run on every package. The output should be posted in
the review.[1]

$ rpmlint SPECS/gns3.spec SRPMS/gns3-0.6.1-1.fc12.src.rpm 
gns3.src: W: spelling-error %description -l en_US topologies -> typologies,
topological, topology
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Does "topology" has plural?

# MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]

Please put licence file in %doc.

# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

%Source0 URL is incorrect.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.